8000 toxgen: Retry & fail if we fail to fetch PyPI data by sentrivana · Pull Request #4251 · getsentry/sentry-python · GitHub
[go: up one dir, main page]
Skip to content

toxgen: Retry & fail if we fail to fetch PyPI data #4251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 9, 2025
Merged

toxgen: Retry & fail if we fail to fetch PyPI data #4251

merged 3 commits into from
Apr 9, 2025

Conversation

sentrivana
Copy link
Contributor
  • try to refetch data if PyPI returns an error
  • if we fail after 3 tries, fail the whole script (it doesn't make sense to run it without access to up-to-date PyPI data)

@codecov Codecov
Copy link
codecov bot commented Apr 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.51%. Comparing base (adcfa0f) to head (72aabf3).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4251      +/-   ##
==========================================
- Coverage   79.54%   79.51%   -0.04%     
==========================================
  Files         142      142              
  Lines       15898    15898              
  Branches     2721     2721              
==========================================
- Hits        12646    12641       -5     
- Misses       2388     2390       +2     
- Partials      864      867       +3

see 5 files with indirect coverage changes

@sentrivana sentrivana changed the title toxgen: Fail if we fail to fetch PyPI data toxgen: Retry & fail if we fail to fetch PyPI data Apr 8, 2025
@sentrivana sentrivana marked this pull request as ready for review April 8, 2025 10:43
@sentrivana sentrivana requested a review from a team as a code owner April 8, 2025 10:43
@sentrivana sentrivana requested a review from antonpirker April 8, 2025 10:43
@sentrivana sentrivana merged commit 2ba4ed0 into master Apr 9, 2025
138 checks passed
@sentrivana sentrivana deleted the ivana/update-tox-yet-again branch April 9, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szokeasaurusrex szokeasaurusrex szokeasaurusrex approved these changes

@antonpirker antonpirker Awaiting requested review from antonpirker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sentrivana @szokeasaurusrex
0