8000 feat(logs): Add sentry.origin attribute for log handler by AbhiPrasad · Pull Request #4250 · getsentry/sentry-python · GitHub
[go: up one dir, main page]
Skip to content

feat(logs): Add sentry.origin attribute for log handler #4250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

feat(logs): Add sentry.origin attribute for log handler #4250

merged 1 commit into from
Apr 9, 2025

Conversation

AbhiPrasad
Copy link
Member

resolves https://linear.app/getsentry/issue/LOGS-13

Docs: https://develop-docs-git-abhi-logs-sdk-developer-documentation.sentry.dev/sdk/telemetry/logs/#default-attributes

If a log is generated by an SDK integration, the SDK should also set the sentry.origin attribute, as per the Trace Origin documentation. It is assumed that logs without a sentry.origin attribute are manually created by the user.

@AbhiPrasad AbhiPrasad requested a review from colin-sentry April 8, 2025 09:28
@AbhiPrasad AbhiPrasad self-assigned this Apr 8, 2025
@AbhiPrasad AbhiPrasad requested a review from a team as a code owner April 8, 2025 09:28
@codecov Codecov
Copy link
codecov bot commented Apr 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.55%. Comparing base (adcfa0f) to head (6916b63).
Report is 4 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4250      +/-   ##
==========================================
+ Coverage   79.54%   79.55%   +0.01%     
==========================================
  Files         142      142              
  Lines       15898    15898              
  Branches     2721     2721              
==========================================
+ Hits        12646    12648       +2     
  Misses       2388     2388              
+ Partials      864      862       -2
Files with missing lines Coverage Δ
sentry_sdk/integrations/logging.py 82.89% <100.00%> (ø)

... and 5 files with indirect coverage changes

@AbhiPrasad AbhiPrasad merged commit 6a1364d into master Apr 9, 2025
138 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-log-origin branch April 9, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentrivana sentrivana sentrivana approved these changes

@colin-sentry colin-sentry Awaiting requested review from colin-sentry

Assignees

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhiPrasad @sentrivana
0