8000 Broader except in django parsed_body by orhanhenrik · Pull Request #4189 · getsentry/sentry-python · GitHub
[go: up one dir, main page]
Skip to content

Broader except in django parsed_body #4189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2025
Merged

Broader except in django parsed_body #4189

merged 1 commit into from
Mar 24, 2025

Conversation

orhanhenrik
Copy link
Contributor

We are seeing internal errors in the Sentry SDK if self.request.data fails. Specifically, it recently failed with rest_framework.exceptions.UnsupportedMediaType: Unsupported media type "" in request..

This exception should not prevent sentry from reporting the original error.

Similar to a previous fix I made #4001

@orhanhenrik orhanhenrik requested a review from a team as a code owner March 24, 2025 06:28
@codecov Codecov
Copy link
codecov bot commented Mar 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.56%. Comparing base (f8ec572) to head (c520622).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4189      +/-   ##
==========================================
- Coverage   79.59%   79.56%   -0.04%     
==========================================
  Files         141      141              
  Lines       15736    15736              
  Branches     2675     2675              
==========================================
- Hits        12525    12520       -5     
- Misses       2367     2369       +2     
- Partials      844      847       +3
Files with missing lines Coverage Δ
sentry_sdk/integrations/django/__init__.py 81.48% <100.00%> (ø)

... and 2 files with indirect coverage changes

@sentrivana sentrivana enabled auto-merge (squash) March 24, 2025 08:50
@sentrivana sentrivana merged commit 4fbcbf0 into getsentry:master Mar 24, 2025
140 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentrivana sentrivana sentrivana approved these c 4F96 hanges

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orhanhenrik @sentrivana
0