8000 Setup scopes before client by sl0thentr0py · Pull Request #3916 · getsentry/sentry-python · GitHub
[go: up one dir, main page]
Skip to content

Setup scopes before client #3916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2025
Merged

Setup scopes before client #3916

merged 1 commit into from
Jan 10, 2025

Conversation

sl0thentr0py
Copy link
Member

The newly added feature flags add an error processor to current_scope in their setup_once. This is actually an antipattern and shouldn't be encouraged.
Either way, this PR sets up the scopes first since the integrations get setup in the Client and require that scope to be correct.

@codecov Codecov
Copy link
codecov bot commented Jan 10, 2025 •
edited
Loading

❌ 294 Tests Failed:

Tests completed Failed Passed Skipped
13321 294 13027 3360
View the top 3 failed tests by shortest run time 
 tests.integrations.celery.test_celery
Stack Traces | 0s run time 
ImportError while importing test module '.../integrations/celery/test_celery.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
.tox/py3.7-celery-v5.1/lib/python3.7.../site-packages/_pytest/python.py:617: in _importtestmodule
    mod = import_path(self.path, mode=importmode, root=self.config.rootpath)
.tox/py3.7-celery-v5.1/lib/python3.7.../site-packages/_pytest/pathlib.py:567: in import_path
    importlib.import_module(module_name)
.../hostedtoolcache/Python/3.7.17.../x64/lib/python3.7/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1006: in _gcd_import
    ???
<frozen importlib._bootstrap>:983: in _find_and_load
    ???
<frozen importlib._bootstrap>:967: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:677: in _load_unlocked
    ???
.tox/py3.7-celery-v5.1/lib/python3.7.../_pytest/assertion/rewrite.py:186: in exec_module
    exec(co, module.__dict__)
.../integrations/celery/test_celery.py:6: in <module>
    from celery import Celery, VERSION
E   ImportError: cannot import name 'Celery' from 'celery' (.../sentry-python/sentry-python/.tox/py3.7-celery-v5.1/lib/python3.7.../site-packages/celery/__init__.py)
 tests.integrations.celery.test_celery_beat_crons
Stack Traces | 0s run time 
ImportError while importing test module '.../integrations/celery/test_celery_beat_crons.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
.tox/py3.7-celery-v5.1/lib/python3.7.../site-packages/_pytest/python.py:617: in _importtestmodule
    mod = import_path(self.path, mode=importmode, root=self.config.rootpath)
.tox/py3.7-celery-v5.1/lib/python3.7.../site-packages/_pytest/pathlib.py:567: in import_path
    importlib.import_module(module_name)
.../hostedtoolcache/Python/3.7.17.../x64/lib/python3.7/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1006: in _gcd_import
    ???
<frozen importlib._bootstrap>:983: in _find_and_load
    ???
<frozen importlib._bootstrap>:967: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:677: in _load_unlocked
    ???
.tox/py3.7-celery-v5.1/lib/python3.7.../_pytest/assertion/rewrite.py:186: in exec_module
    exec(co, module.__dict__)
.../integrations/celery/test_celery_beat_crons.py:6: in <module>
    from celery.schedules import crontab, schedule
.tox/py3.7-celery-v5.1/lib/python3.7.../site-packages/celery/schedules.py:12: in <module>
    from . import current_app
E   ImportError: cannot import name 'current_app' from 'celery' (.../sentry-python/sentry-python/.tox/py3.7-celery-v5.1/lib/python3.7.../site-packages/celery/__init__.py)
 tests.integrations.celery.test_update_celery_task_headers
Stack Traces | 0s run time 
.../integrations/celery/beat.py:28: in <module>
    from celery import Task, Celery  # type: ignore
E   ImportError: cannot import name 'Task' from 'celery' (.../sentry-python/sentry-python/.tox/py3.7-celery-v5.1/lib/python3.7.../site-packages/celery/__init__.py)

During handling of the above exception, another exception occurred:
.../integrations/celery/test_update_celery_task_headers.py:7: in <module>
    from sentry_sdk.integrations.celery import _update_celery_task_headers
.../integrations/celery/__init__.py:9: in <module>
    from sentry_sdk.integrations.celery.beat import (
.../integrations/celery/beat.py:37: in <module>
    raise DidNotEnable("Celery not installed")
E   sentry_sdk.integrations.DidNotEnable: Celery not installed

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

antonpirker
antonpirker approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member
@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sl0thentr0py sl0thentr0py merged commit ab5d8a7 into potel-base Jan 10, 2025
97 of 126 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/potel/reorder-init-scope branch January 10, 2025 13:39
@sl0thentr0py sl0thentr0py mentioned this pull request Jan 10, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonpirker antonpirker antonpirker approved these changes

@sentrivana sentrivana Awaiting requested review from sentrivana

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sl0thentr0py @antonpirker
0