8000 Fix aiohttp tests by sl0thentr0py · Pull Request #3771 · getsentry/sentry-python · GitHub
[go: up one dir, main page]
Skip to content

Fix aiohttp tests #3771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2024
Merged

Fix aiohttp tests #3771

merged 1 commit into from
Nov 13, 2024

Conversation

sl0thentr0py
Copy link
Member

Remove explicit trace_id passing

@sl0thentr0py
Fix aiohttp tests
fbb9067 
Remove explicit trace_id passing
@codecov Codecov
8000
Copy link
codecov bot commented Nov 13, 2024 •
edited
Loading

❌ 1609 Tests Failed:

Tests completed Failed Passed Skipped
19899 1609 18290 4412
View the top 1 failed tests by shortest run time 
tests.test_utils test_datetime_from_isoformat[2021-01-01T00:00:00.000000-00:00-expected_output4]
Stack Traces | 0.001s run time 
tests/test_utils.py:109: in test_datetime_from_isoformat
    assert datetime_from_isoformat(input_str) == expected_output, input_str
E   NameError: name 'datetime_from_isoformat' is not defined
View the full list of 2 ❄️ flaky tests 
tests.test_utils test_datetime_from_isoformat[2021-01-01T00:00:00.000000-0000-expected_output6]

Flake rate in main: 35.42% (Passed 31 times, Failed 17 times)

Stack Traces | 0.001s run time 
tests/test_utils.py:109: in test_datetime_from_isoformat
    assert datetime_from_isoformat(input_str) == expected_output, input_str
E   NameError: name 'datetime_from_isoformat' is not defined
tests.test_scope test_with_isolation_scope_data

Flake rate in main: 99.07% (Passed 2 times, Failed 213 times)

Stack Traces | 0.001s run time 
tests/test_scope.py:387: in test_with_isolation_scope_data
    assert scope._tags == {"before_isolation_scope": 1}
E   AssertionError: assert {} == {'before_isolation_scope': 1}
E     
E     Right contains 1 more item:
E     {'before_isolation_scope': 1}
E     
E     Full diff:
E     + {}
E     - {
E     -     'before_isolation_scope': 1,
E     - }

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@sl0thentr0py sl0thentr0py merged commit 09b4a01 into potel-base Nov 13, 2024
26 of 116 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/potel/fix-aiohttp branch November 13, 2024 14:10
@sl0thentr0py sl0thentr0py mentioned this pull request Nov 13, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sl0thentr0py @sentrivana
0