8000 [Breaking] Remove deprecated `propagate_traces` option. by nellaG · Pull Request #3725 · getsentry/sentry-python · GitHub
[go: up one dir, main page]
Skip to content

[Breaking] Remove deprecated propagate_traces option. #3725

< 8000 summary id="button-af09cc044cdcdb62" class="btn btn-sm btn-primary m-0 ml-0 ml-md-2" > New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

[Breaking] Remove deprecated propagate_traces option. #3725

wants to merge 7 commits into from

Conversation

nellaG
Copy link
@nellaG nellaG commented Nov 2, 2024 •
edited by antonpirker
Loading

The propagate_traces option is not documented and was superseded by trace_propagation_targets. This has been deprecated for a while and will now be removed.

Refs #3106

nellaG and others added 2 commits November 2, 2024 15:17
@nellaG
ref(celery): remove deprecated propagate_traces option
b8ef896 
`propagate_traces` is not documented and superseded by
`trace_propagation_targets`.

Refs getsentry#3106
@antonpirker
Merge branch 'master' into feature/deprecate-propagate_traces
94100fb
@antonpirker
Copy link
Member

Hey @nellaG,

thanks for the contribution! As this has to go out in a Major (it will be part in SDK 3.0) this will stay around for some while until we are ready to prepare 3.0. So I guess this will happen somewhen in spring 2025.

@szokeasaurusrex szokeasaurusrex mentioned this pull request Jan 2, 2025
Closed
@antonpirker antonpirker added SDK 3.0 Breaking change needs to go out in a major labels Jan 14, 2025
@antonpirker antonpirker changed the title ref(celery): remove deprecated propagate_traces option [Breaking] Remove deprecated propagate_traces option. Jan 14, 2025
@codecov Codecov
Copy link
codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.12%. Comparing base (9ff100a) to head (367d2a6).
Report is 125 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3725      +/-   ##
==========================================
- Coverage   80.15%   80.12%   -0.03%     
==========================================
  Files         139      139              
  Lines       15391    15388       -3     
  Branches     2596     2595       -1     
==========================================
- Hits        12337    12330       -7     
- Misses       2208     2220      +12     
+ Partials      846      838       -8
Files with missing lines Coverage Δ
sentry_sdk/consts.py 93.27% <ø> (ø)
sentry_sdk/integrations/celery/__init__.py 86.49% <100.00%> (-0.06%) ⬇️
sentry_sdk/scope.py 85.39% <ø> (+0.23%) ⬆️

... and 4 files with indirect coverage changes

sentrivana
sentrivana requested changes Feb 17, 2025
View reviewed changes
Copy link
Contributor
@sentrivana sentrivana left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nellaG, thank you for the contribution!

There are two options named propagate_traces, one is a general SDK option (the one in sentry_sdk/consts.py) and one is a Celery integration specific option. We only want to remove the general one, but leave propagate_traces untouched in all Celery files.

@sentrivana
Copy link
Contributor

Continuing this in #4206.

@sentrivana sentrivana closed this Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentrivana sentrivana sentrivana requested changes

Assignees
No one assigned
Labels
Breaking change needs to go out in a major SDK 3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nellaG @antonpirker @sentrivana
0