8000 Fix pymongo by sentrivana · Pull Request #3688 · getsentry/sentry-python · GitHub
[go: up one dir, main page]
Skip to content

Fix pymongo #3688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 24, 2024
Merged

Fix pymongo #3688

merged 4 commits into from
Oct 24, 2024

Conversation

sentrivana
Copy link
Contributor
@sentrivana sentrivana commented Oct 23, 2024 •
edited
Loading

Fix pymongo spans/breadcrumbs.

❗ Important: With this PR we're now stripping commas and equals signs from all span names because they're not supported in OTel tracestate values.

@codecov Codecov
Copy link
codecov bot commented Oct 23, 2024 •
edited
Loading

❌ 3030 Tests Failed:

Tests completed Failed Passed Skipped
20403 3030 17373 4475
View the top 3 failed tests by shortest run time 
tests.integrations.litestar.test_litestar test_middleware_spans
Stack Traces | 0s run time 
No failure message available

tests.integrations.litestar.test_litestar test_span_origin
Stack Traces | 0s run time 
No failure message available

tests.test_scope test_with_isolation_scope_data
Stack Traces | 0.001s run time 
tests/test_scope.py:387: in test_with_isolation_scope_data
    assert scope._tags == {"before_isolation_scope": 1}
E   AssertionError: assert {} == {'before_isolation_scope': 1}
E     Right contains 1 more item:
E     {'before_isolation_scope': 1}
E     Full diff:
E     - {'before_isolation_scope': 1}
E     + {}

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@sentrivana sentrivana marked this pull request as ready for review October 24, 2024 08:47
antonpirker
antonpirker approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member
@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍 for updating migration guide in same PR!

@sentrivana sentrivana mentioned this pull request Oct 24, 2024
Closed
54 tasks
@sentrivana sentrivana merged commit a2dff73 into potel-base Oct 24, 2024
15 of 120 checks passed
@sentrivana sentrivana deleted the ivana/potel/fix-pymongo branch October 24, 2024 10:47
@sentrivana sentrivana mentioned this pull request Oct 24, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonpirker antonpirker antonpirker approved these changes

@sl0thentr0py sl0thentr0py Awaiting requested review from sl0thentr0py

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sentrivana @antonpirker
0