8000 ref: Unify required imports mechanism for integrations by BYK · Pull Request #3597 · getsentry/sentry-python · GitHub
[go: up one dir, main page]
Skip to content

ref: Unify required imports mechanism for integrations #3597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ref: Unify required imports mechanism for integrations #3597

wants to merge 1 commit into from

Conversation

BYK
Copy link
Member
@BYK BYK commented Oct 2, 2024

Follow up to #3548 for better testing and standardisation on
required imports/modules for integrations.

@BYK
ref: Unify required imports mechanism for integrations
ba54153 
Follow up to #3548 for better testing and standardisation on
required imports/modules for integrations.
@codecov Codecov
Copy link
codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 52.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 38.59%. Comparing base (1c64ff7) to head (ba54153).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
sentry_sdk/integrations/__init__.py 61.11% 7 Missing ⚠️
sentry_sdk/integrations/aiohttp.py 20.00% 4 Missing ⚠️
sentry_sdk/integrations/redis/__init__.py 50.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (1c64ff7) and HEAD (ba54153). Click for more details.

HEAD has 11 uploads less than BASE
Flag BASE (1c64ff7) HEAD (ba54153)
112 101
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #3597       +/-   ##
===========================================
- Coverage   84.34%   38.59%   -45.75%     
===========================================
  Files         133      133               
  Lines       13929    13940       +11     
  Branches     2938     2940        +2     
===========================================
- Hits        11748     5380     -6368     
- Misses       1443     8173     +6730     
+ Partials      738      387      -351
Files with missing lines Coverage Δ
sentry_sdk/integrations/redis/__init__.py 66.66% <50.00%> (-25.65%) ⬇️
sentry_sdk/integrations/aiohttp.py 17.79% <20.00%> (-66.05%) ⬇️
sentry_sdk/integrations/__init__.py 79.76% <61.11%> (-14.27%) ⬇️

... and 110 files with indirect coverage changes

@BYK BYK closed this by deleting the head repository Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BYK
0