10000 Set the correct SpanContext in continue_trace by sl0thentr0py · Pull Request #3475 · getsentry/sentry-python · GitHub
[go: up one dir, main page]
Skip to content

Set the correct SpanContext in continue_trace #3475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2024
Merged

Set the correct SpanContext in continue_trace #3475

merged 1 commit into from
Aug 30, 2024

Conversation

sl0thentr0py
Copy link
Member
@sl0thentr0py sl0thentr0py commented Aug 29, 2024 •
edited
Loading

This commit makes incoming distributed tracing work and finishes implementing continue_trace

  • Updates the span processor to consider remote parents as root spans
  • Adds a simpler start_span to POTelScope for now that is a simplified version of the original that just creates a POTelSpan
  • continue_trace now adds a fake remote NonRecordingSpan with the correct trace_id, parent_span_id and parent_sampled fields taken from the PropagationContext
  • fix the trace_id and span_id properties on POTelSpan

closes #3476

@codecov Codecov
Copy link
codecov bot commented Aug 29, 2024 •
edited
Loading

❌ 3863 Tests Failed:

Tests completed Failed Passed Skipped
16709 3863 12846 1916
View the top 3 failed tests by shortest run time 
tests.integrations.celery.test_celery test_abstract_task[<lambda>2]
Stack Traces | 0s run time 
No failure message available

tests.integrations.celery.test_celery test_simple_without_performance[<lambda>2]
Stack Traces | 0s run time 
No failure message available

tests.integrations.clickhouse_driver.test_clickhouse_driver test_clickhouse_dbapi_spans_with_pii
Stack Traces | 0s run time 
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@sl0thentr0py sl0thentr0py force-pushed the neel/potel/is-remote branch 3 times, most recently from 2f4e723 to d037a10 Compare August 29, 2024 15:41
@sl0thentr0py sl0thentr0py changed the title Set the correct SpanContext in continue_trace Set the correct SpanContext in continue_trace and make distributed tracing work Aug 29, 2024
@sl0thentr0py sl0thentr0py changed the title Set the correct SpanContext in continue_trace and make distributed tracing work Set the correct SpanContext in continue_trace Aug 29, 2024
@sl0thentr0py
Copy link
Member Author

working distributed trace

tested with

image
image

sentrivana
sentrivana approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor
@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 👍🏻 👍🏻 lgtm

sentry_sdk/integrations/opentelemetry/scope.py

def start_span(self, span=None, custom_sampling_context=None, **kwargs):
# type: (Optional[POTelSpan], Optional[SamplingContext], Any) -> POTelSpan
# TODO-neel-potel ideally want to remove the span argument, discuss with ivana
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the only use for this was using the Transaction from continue_trace, let's get rid of the arg

@sl0thentr0py sl0thentr0py merged commit 2e2be3b into potel-base Aug 30, 2024
3 of 31 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/potel/is-remote branch August 30, 2024 11:56
This was referenced Aug 30, 2024
Draft
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentrivana sentrivana sentrivana approved these changes

@szokeasaurusrex szokeasaurusrex Awaiting requested review from szokeasaurusrex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sl0thentr0py @sentrivana
0