Bottle redirect fix #317
Merged
Bottle redirect fix #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should be already contained in the line above
untitaker
requested changes
Apr 3, 2019
sentry_sdk/integrations/bottle.py
Outdated
| res = prepared_callback(*args, **kwargs) | ||
| except Exception as exception: | ||
| def capture_exception(exception): | ||
| hub = Hub.current |
Member
There was a problem hiding this comment.
I forgot this when reviewing your first PR, but you can use the hub variable from outer scope.
Contributor
Author
There was a problem hiding this comment.
You're right. Thanks for noticing.
sentry_sdk/integrations/bottle.py
Outdated
| try: | ||
| res = prepared_callback(*args, **kwargs) | ||
| except HTTPResponse as exception: | ||
| if exception.status == 500: |
Member
There was a problem hiding this comment.
Are those exceptions even interesting?
Contributor
Author
There was a problem hiding this comment.
It seems not. I'll skip all. Thanks.
using `hub` variable from outer scope
skip all HTTPResponse exceptions
untitaker
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out that a sentry record is created when a Bottle redirect is performed.
This MR should fix that.
I also included a small tox.ini update.