Add function to extract sentry trace info from traceparent string. #1771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we already have this in python, do we really need this? sentry-python/sentry_sdk/tracing_utils.py Line 217 in 1c886e6 plus this is not using the regex so it's a less precise implementation to just split on the dashes |
Base automatically changed from
antonpirker/1687-basic-otel-support-3b-timestamps
to
antonpirker/1687-basic-otel-support-2-instrumenter
November 30, 2022 15:54
|
Oh, good to know! Will close and use the existing thing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically the opposite of
to_traceparent().