8000 fix: Fix confusing/buggy push_scope behavior with callbacks by untitaker · Pull Request #156 · getsentry/sentry-python · GitHub
[go: up one dir, main page]
Skip to content

fix: Fix confusing/buggy push_scope behavior with callbacks #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 31, 2018
Merged

fix: Fix confusing/buggy push_scope behavior with callbacks #156

merged 3 commits into from
Oct 31, 2018

Conversation

untitaker
Copy link
Member

No description provided.

@untitaker untitaker changed the title fix: Fix confusing/buggy push_scope behavior fix: Fix confusing/buggy push_scope behavior with callbacks Oct 28, 2018
@codecov-io
Copy link
codecov-io commented Oct 28, 2018 •
edited
Loading

Codecov Report

Merging #156 into master will increase coverage by 0.44%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   67.09%   67.53%   +0.44%     
==========================================
  Files          28       28              
  Lines        2747     2760      +13     
  Branches      389      432      +43     
==========================================
+ Hits         1843     1864      +21     
+ Misses        751      727      -24     
- Partials      153      169      +16
Impacted Files Coverage Δ
sentry_sdk/hub.py 77.83% <100%> (+2.18%) ⬆️
sentry_sdk/integrations/argv.py 81.25% <0%> (-11.61%) ⬇️
sentry_sdk/integrations/dedupe.py 90.47% <0%> (-9.53%) ⬇️
sentry_sdk/integrations/modules.py 80.76% <0%> (-6.74%) ⬇️
sentry_sdk/integrations/atexit.py 86.66% <0%> (-6.2%) ⬇️
sentry_sdk/integrations/excepthook.py 76.92% <0%> (-3.08%) ⬇️
sentry_sdk/worker.py 82.14% <0%> (-2.2%) ⬇️
sentry_sdk/scope.py 64.8% <0%> (-2.15%) ⬇️
sentry_sdk/integrations/stdlib.py 72.91% <0%> (-1.56%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4ebca8...49b6772. Read the comment docs.

@untitaker untitaker requested review from mitsuhiko and HazAT October 28, 2018 18:37
HazAT
HazAT approved these changes Oct 31, 2018
View reviewed changes
8000
@HazAT
Copy link
Member
HazAT commented Oct 31, 2018

lol, two approves are better than one

@untitaker untitaker merged commit 3fe8712 into master Oct 31, 2018
@untitaker untitaker deleted the fix/push-scope-behavior branch October 31, 2018 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT approved these changes

@mitsuhiko mitsuhiko Awaiting requested review from mitsuhiko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@untitaker @codecov-io @HazAT
0