8000 fix: Ensure drained queue when RQ kills job by untitaker · Pull Request #153 · getsentry/sentry-python · GitHub
[go: up one dir, main page]
Skip to content

fix: Ensure drained queue when RQ kills job #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 27, 2018
Merged

fix: Ensure drained queue when RQ kills job #153

merged 5 commits into from
Oct 27, 2018

Conversation

untitaker
Copy link
Member

Fix #152

@codecov-io
Copy link
codecov-io commented Oct 26, 2018 •
edited
Loading

Codecov Report

Merging #153 into master will decrease coverage by 0.03%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
- Coverage   67.09%   67.05%   -0.04%     
==========================================
  Files          28       28              
  Lines        2744     2747       +3     
  Branches      388      389       +1     
==========================================
+ Hits         1841     1842       +1     
- Misses        750      751       +1     
- Partials      153      154       +1
Impacted Files Coverage Δ
sentry_sdk/integrations/rq.py 68.96% <50%> (-1.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a11f3f3...da7b787. Read the comment docs.

@untitaker untitaker merged commit 2d21404 into master Oct 27, 2018
@untitaker untitaker deleted the fix/rq-job-shutdown branch October 27, 2018 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@untitaker @codecov-io
0