8000 fix: Make the main hub the current hub for main thread by mitsuhiko · Pull Request #119 · getsentry/sentry-python · GitHub
[go: up one dir, main page]
Skip to content

fix: Make the main hub the current hub for main thread #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2018
Merged

fix: Make the main hub the current hub for main thread #119

merged 1 commit into from
Oct 11, 2018

Conversation

mitsuhiko
Copy link
Contributor

No description provided.

@mitsuhiko mitsuhiko requested a review from untitaker October 10, 2018 09:18
@codecov-io
Copy link
codecov-io commented Oct 10, 2018 •
edited
Loading

Codecov Report

Merging #119 into master will decrease coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage   66.91%   66.76%   -0.15%     
==========================================
  Files          25       25              
  Lines        2457     2458       +1     
  Branches      352      352              
==========================================
- Hits         1644     1641       -3     
- Misses        680      682       +2     
- Partials      133      135       +2
Impacted Files Coverage Δ
sentry_sdk/hub.py 75.64% <100%> (+0.12%) ⬆️
sentry_sdk/integrations/stdlib.py 74.46% <0%> (-8.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df92dda...d20283f. Read the comment docs.

@untitaker
Copy link
Member

What if sentry_sdk is imported from a non-main thread?

@mitsuhiko mitsuhiko merged commit 69c084f into master Oct 11, 2018
@mitsuhiko mitsuhiko deleted the feature/make-main-current branch October 11, 2018 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untitaker untitaker Awaiting requested review from untitaker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitsuhiko @codecov-io @untitaker
0