Get rid of setup.cfg by moving the only option to setup.py #1040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Mar 4, 2021
Member
There was a problem hiding this comment.
Thanks, I didn't know you can do that!
Contributor
Author
|
Python packaging is a land full of mysteries. ;) I've been told it once by the maintainers in connection with my PyPI blog post. |
Member
|
Do you know by chance when this feature was introduced? I mean, seems to run fine on last pip for 2.7, but we have people running on 2.6. |
Contributor
Author
|
I don't think this is a pip feature but a setuptools/wheel one. Assuming it's a recent-ish features (which I don't think), it would only affect people who insist on building their sdists with ancient build chains into wheels. |
Member
|
Fair enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉