10000 chore: Create `dev-packages` folder by lforst · Pull Request #9997 · getsentry/sentry-javascript · GitHub
[go: up one dir, main page]
Skip to content

chore: Create dev-packages folder #9997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jan 3, 2024
Merged

chore: Create dev-packages folder #9997

merged 20 commits into from
Jan 3, 2024

Conversation

lforst
Copy link
Contributor
@lforst lforst commented Dec 29, 2023 •
edited
Loading

We wanted to do this for a long time. Generally this is a bit of busy work but it may make the navigation in our folders a bit more bearable considering the repo grew a lot over the last year.

Creates a dev-packages folder and moves all packages that we do not publish AND that do not contain runtime code into it.

@lforst lforst force-pushed the lforst-workspace-cleanup branch from 4f417a4 to 044d192 Compare January 2, 2024 10:40
@lforst lforst marked this pull request as ready for review January 2, 2024 13:26
@lforst lforst requested review from mydea, Lms24 and AbhiPrasad January 2, 2024 13:26
AbhiPrasad
AbhiPrasad approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member
@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP merge conflicts

8000
Lms24
Lms24 approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member
@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this change - I think it really cleans up our repo structure!

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jan 3, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 75.94 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 67.3 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 60.93 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.88 KB (+0.06% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 30.42 KB (0%)
@sentry/browser - Webpack (gzipped) 22.12 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 73.34 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 65.01 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 31.16 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 23.16 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 203.92 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 93.81 KB (+0.05% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 68.73 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 34.12 KB (+0.03% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 67.71 KB (+0.02% 🔺)
@sentry/react - Webpack (gzipped) 22.16 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 84.35 KB (+0.02% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 48.99 KB (+0.03% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 16.63 KB (0%)

@lforst lforst merged commit 35205b4 into develop Jan 3, 2024
@lforst lforst deleted the lforst-workspace-cleanup branch January 3, 2024 09:09
anonrig pushed a commit that referenced this pull request Jan 3, 2024
@lforst @anonrig
chore: Create dev-packages folder (#9997)
da37224
@AbhiPrasad AbhiPrasad mentioned this pull request Jan 17, 2024
Merged
AbhiPrasad added a commit that referenced this pull request Jan 17, 2024
@AbhiPrasad
chore: Update .git-blame-ignore-revs for dev-package changes (#10221)
a5d1d7b 
Trying to do a git blame to investigate some stuff, figured would be
nice to ignore the changes in #9997 since it affects many files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@mydea mydea Awaiting requested review from mydea

Assignees
No one assigned
Labels
ci-skip-cache
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lforst @Lms24 @AbhiPrasad
0