-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(replay): Capture hydration error breadcrumb #9759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds a hydration error breadcrumb for nextjs / other ssr frameworks
size-limit report 📦
|
i don't know how reviews work in this repo so i tagged some names i saw in blame |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can cut a release asap to get this out after we merge in.
IMO doesn't feel amazing to have react specific logic in replay integration like this, but there's not really a better place to keep it I guess :/
In the future, you can tag @getsentry/ team-web-sdk-frontend (no space) and it'll round robin two of of the js sdk maintainers to review.
renamed to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more naming thing and we are good 🚢 🇮🇹
Please make sure you squash commit - we allow for merge but thats to make gitflow work properly between develop
and master
.
…eplay Details page (#61477) Reads the new `session-replay-show-hydration-errors` feature flag which controls if we show `replay.hydrate-error` crumbs on the Replay Details page. These crumbs have a poor design right now, but they have a button which will open a Modal that shows a visual side-by-side comparison of before & after the hydration error happened. Also, it shows a diff of the html. <img width="1426" alt="SCR-20231208-ninr" src="https://github.com/getsentry/sentry/assets/187460/2b5b172d-024d-4535-98d9-86493405c523"> Depends on #61612 See related SDK change: getsentry/sentry-javascript#9759 fixes #61613 --------- Co-authored-by: Scott Cooper <scttcper@gmail.com>
Adds a hydration error breadcrumb
replay.hydrate-error
for nextjs / other react ssr frameworks.fixes #9649