8000 test: Use `getLocalTestUrl` instead of `getLocalTestPath` for xhr tests by mydea · Pull Request #8719 · getsentry/sentry-javascript · GitHub
[go: up one dir, main page]
Skip to content

test: Use getLocalTestUrl instead of getLocalTestPath for xhr tests #8719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2023
Merged

test: Use getLocalTestUrl instead of getLocalTestPath for xhr tests #8719

merged 1 commit into from
Aug 7, 2023

Conversation

mydea
Copy link
Member
@mydea mydea commented Aug 2, 2023

Hoping this unflakes some stuff...

Closes #8717

@mydea mydea self-assigned this Aug 2, 2023
@github-actions
Copy link
Contributor
github-actions bot commented Aug 2, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 74.7 KB (-0.55% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.11 KB (-0.98% 🔽)
@sentry/browser - Webpack (gzipped) 21.81 KB (-0.69% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.52 KB (-0.49% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.14 KB (-0.59% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.15 KB (-0.96% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 218.93 KB (-0.99% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 84.63 KB (-1.66% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 59.8 KB (-1.23% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 30.43 KB (+0.01% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 64.91 KB (-0.41% 🔽)
@sentry/react - Webpack (gzipped) 21.84 KB (-0.63% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 92.52 KB (-0.45% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.61 KB (-0.54% 🔽)

@mydea mydea marked this pull request as ready for review August 2, 2023 14:17
@mydea mydea requested review from a team, stephanie-anderson, Lms24 and lforst and removed request for a team and stephanie-anderson August 2, 2023 14:17
AbhiPrasad
AbhiPrasad approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member
@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we stop using getLocalTestPath across the board then?

Lms24
Lms24 approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member
@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why getLocalTestPath was causing flakes?

@mydea
Copy link
Member Author
mydea commented Aug 4, 2023

Can you explain why getLocalTestPath was causing flakes?

I can't 😅 it was just a guess that it could be related to file URLs and get, it may not be the problem, but I figured it doesn't hurt. Probably we can/should move all/most usage over because it is more "realistic" to a real-world usage IMHO. Just saw a few flakes here and there for the get tests etc. and don't really see much in the tests that could explain this 😬

@mydea mydea merged commit e0e246d into develop Aug 7, 2023
@mydea mydea deleted the fn/try-unflake-test branch August 7, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@lforst lforst Awaiting requested review from lforst

Assignees

@mydea mydea

Labels
Type: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Flaky CI]: suites/integrations/Breadcrumbs/fetch/get/test.ts
3 participants
@mydea @Lms24 @AbhiPrasad
0