8000 chore(ci): Add Node 20 to the test matrix by AbhiPrasad · Pull Request #7904 · getsentry/sentry-javascript · GitHub
[go: up one dir, main page]
Skip to content

chore(ci): Add Node 20 to the test matrix #7904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 19, 2023
Merged

chore(ci): Add Node 20 to the test matrix #7904

merged 2 commits into from
Apr 19, 2023

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad requested review from a team, lforst and Lms24 and removed request for a team April 19, 2023 12:40
@AbhiPrasad
Copy link
Member Author

Making CI even slower 😎

@github-actions
Copy link
Contributor
github-actions bot commented Apr 19, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.97 KB (-0.36% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 65.48 KB (-0.28% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.51 KB (-0.4% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 57.94 KB (-0.31% 🔽)
@sentry/browser - Webpack (gzipped + minified) 21.11 KB (-0.35% 🔽)
@sentry/browser - Webpack (minified) 68.89 KB (-0.26% 🔽)
@sentry/react - Webpack (gzipped + minified) 21.14 KB (-0.35% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 48.98 KB (-0.15% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.54 KB (-0.27% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.77 KB (-0.3% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 45.35 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 39.28 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 64.22 KB (-0.12% 🔽)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 57.19 KB (-0.13% 🔽)

@AbhiPrasad
Copy link
Member Author

In b4fe61f I removed Node 20 from the remix/next.js integration tests. Will create follow up issues for these.

I think remix is also aware of Node 20 not being very cooperative: remix-run/remix#6099, let's wait till they get stuff fixed.

@AbhiPrasad AbhiPrasad merged commit 63d1937 into develop Apr 19, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-node-20 branch April 19, 2023 13:24
@AbhiPrasad AbhiPrasad mentioned this pull request Apr 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@lforst lforst Awaiting requested review from lforst lforst was automatically assigned from getsentry/team-web-sdk-frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhiPrasad @Lms24
0