8000 fix(sveltekit): Handle same origin and destination navigations correctly by Lms24 · Pull Request #7584 · getsentry/sentry-javascript · GitHub
[go: up one dir, main page]
Skip to content

fix(sveltekit): Handle same origin and destination navigations correctly #7584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2023
Merged

fix(sveltekit): Handle same origin and destination navigations correctly #7584

merged 1 commit into from
Mar 23, 2023

Conversation

Lms24
Copy link
Member
@Lms24 Lms24 commented Mar 23, 2023

Previously our Kit routing instrumentation used the parameterized route id to determine if the origin and destination of the navigation were identical (in which case we don't want to create a navigation transaction).
This caused navigations from e.g. /users/123 to users/456 to not create a transaction because their route id was identical. This PR fixes this bug by using the raw URL which we also get from the navigating store emissions.

Furthermore, this PR fixes the transaction source which previously was always set to route, even if no route id was available.

ref #7413

@Lms24 Lms24 requested a review from AbhiPrasad March 23, 2023 09:18
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.57 KB (+0.02% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 64.2 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.13 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 56.58 KB (+0.02% 🔺)
@sentry/browser - Webpack (gzipped + minified) 21.59 KB (+0.02% 🔺)
@sentry/browser - Webpack (minified) 71.66 KB (+0.02% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.61 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified) 51.87 KB (+0.04% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.92 KB (+0.08% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.09 KB (+0.08% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.33 KB (+0.08% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.39 KB (+0.09% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 62.53 KB (+0.08% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 56.07 KB (+0.07% 🔺)

@Lms24 Lms24 merged commit 1121507 into develop Mar 23, 2023
@Lms24 Lms24 deleted the lms/sveltekit-fix-routing-instrumentation-urls branch March 23, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lms24 @AbhiPrasad
0