8000 fix(nextjs): Add tracing extension methods in `wrapServerComponentWithSentry` by Lms24 · Pull Request #7567 · getsentry/sentry-javascript · GitHub
[go: up one dir, main page]
Skip to content

fix(nextjs): Add tracing extension methods in wrapServerComponentWithSentry #7567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2023
Merged

fix(nextjs): Add tracing extension methods in wrapServerComponentWithSentry #7567

merged 2 commits into from
Mar 22, 2023

Conversation

Lms24
Copy link
Member
@Lms24 Lms24 commented Mar 22, 2023 •
edited
Loading

Our E2E tests were failing because apparently we don't initialize a client while building a NextJS app. This caused the tracing extension methods to not be added, resulting in startTransaction returning undefined. Not sure if this is the best way to fix this but it seems to work (h/t @timfish for the fix).

cc @lforst might be good if you take a look at this once you're back

@Lms24 Lms24 changed the title fix(nextjs): Add extension methods in wrapServerComponentWithSentry fix(nextjs): Add tracing extension methods in wrapServerComponentWithSentry Mar 22, 2023
@github-actions
Copy link
Contributor
github-actions bot commented Mar 22, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.44 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 63.52 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.13 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 56.57 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.59 KB (0%)
@sentry/browser - Webpack (minified) 71.65 KB (+0.01% 🔺)
@sentry/react - Webpack (gzipped + minified) 21.61 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 51.85 KB (-0.21% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.77 KB (+0.06% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.08 KB (+0.07% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 44.21 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 38.28 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 62.4 KB (+0.02% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 55.95 KB (0%)

@Lms24 Lms24 marked this pull request as ready for review March 22, 2023 14:09
@Lms24 Lms24 self-assigned this Mar 22, 2023
@Lms24 Lms24 requested review from timfish and AbhiPrasad March 22, 2023 14:09
@Lms24 Lms24 force-pushed the lms/fix-nextjs-extension-methods branch from 435da44 to 48ec741 Compare March 22, 2023 14:10
@Lms24 Lms24 merged commit 046c0c2 into develop Mar 22, 2023
@Lms24 Lms24 deleted the lms/fix-nextjs-extension-methods branch March 22, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timfish timfish timfish approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees

@Lms24 Lms24

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lms24 @timfish @AbhiPrasad
0