test(node): Add integration test for Postgres auto-instrumentation. #4804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
AbhiPrasad
reviewed
Mar 28, 2022
| }); | ||
|
|
||
| const client = new pg.Client(); | ||
| client.query('test_query', ['a', 'b'], () => transaction.finish()); |
There was a problem hiding this comment.
Could we look at nested queries? Also simulate actual queries like SELECT * ...? TIL that we literally on instrument .query.
There was a problem hiding this comment.
@AbhiPrasad, updated 👍
AbhiPrasad
reviewed
Mar 28, 2022
| expect(envelope).toHaveLength(3); | ||
|
|
||
| assertSentryTransaction(envelope[2], { | ||
| transaction: 'Test Transaction', |
There was a problem hiding this comment.
Can we assert a proper parent-child relationship between the spans?
There was a problem hiding this comment.
Checked again and looks like these are not really nested queries, just serialized. So, each is a child of the main transaction. Sub-queries seem to be handled on query level, and our integration is not covering it.
AbhiPrasad
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #4762
Also, not adding
pg-nativetests, as that package has platform specific dependencies that require separate installations.