8000 fix(ember): Allow ember-beta tests to fail by lobsterkatie · Pull Request #3910 · getsentry/sentry-javascript · GitHub
[go: up one dir, main page]

Skip to content

fix(ember): Allow ember-beta tests to fail #3910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 27, 2021

Conversation

lobsterkatie
Copy link
Member
@lobsterkatie lobsterkatie commented Aug 20, 2021

Though it's good to have a record of whether or not any given version of the SDK code plays nicely with ember-beta, it shouldn't be a blocker.

See also #3104 and the conversation in getsentry/publish#495.

8000
@kamilogorek
Copy link
Contributor

Makes sense

@github-actions
Copy link
Contributor
github-actions bot commented Aug 20, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 21.57 KB (-0.01% 🔽)
@sentry/browser - Webpack 22.57 KB (0%)
@sentry/react - Webpack 22.6 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29 KB (-0.01% 🔽)

@kamilogorek
Copy link
Contributor

The only way I found locally to make the CI pass is to remove this beta entry entirely ¯_(ツ)_/¯

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) August 27, 2021 14:58
@AbhiPrasad AbhiPrasad merged commit 949f1b6 into master Aug 27, 2021
@AbhiPrasad AbhiPrasad deleted the kmclb-allow-ember-beta-to-fail branch August 27, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0