8000 build(ci): Make ember test runs more restrictive by AbhiPrasad · Pull Request #3906 · getsentry/sentry-javascript · GitHub
[go: up one dir, main page]
Skip to content

build(ci): Make ember test runs more restrictive #3906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2021
Merged

build(ci): Make ember test runs more restrictive #3906

merged 1 commit into from
Aug 19, 2021

Conversation

AbhiPrasad
Copy link
Member

Only run ember tests if the ember package has been changed. Previously
we would run ember tests if ember or any of it's dependencies changed
(like hub, core, types etc.)

@AbhiPrasad
build(ci): Make ember test runs more restrictive
c4fe225 
Only run ember tests if the ember package has been changed. Previously
we would run ember tests if ember or any of it's dependencies changed
(like hub, core, types etc.)
@kamilogorek
Copy link
Contributor

It's not perfect, as changes to dependencies can affect the behavior of the SDK, but I'm fine with it in this case.

@github-actions
Copy link
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 21.57 KB (-0.01% 🔽)
@sentry/browser - Webpack 22.57 KB (0%)
@sentry/react - Webpack 22.6 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29 KB (-0.01% 🔽)

@AbhiPrasad AbhiPrasad merged commit e46ff3e into master Aug 19, 2021
@AbhiPrasad AbhiPrasad deleted the abhi-ember-test-select branch August 19, 2021 12:49
AbhiPrasad added a commit that referenced this pull request Aug 19, 2021
@AbhiPrasad
build(ci): Make ember test runs more restrictive (#3906)
49f7787 
Only run ember tests if the ember package has been changed. Previously
we would run ember tests if ember or any of it's dependencies changed
(like hub, core, types etc.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilogorek kamilogorek kamilogorek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhiPrasad @kamilogorek
0