8000 ref(gatsby): Make `@sentry/tracing` mandatory + add tests by AbhiPrasad · Pull Request #2841 · getsentry/sentry-javascript · GitHub
[go: up one dir, main page]
Skip to content

ref(gatsby): Make @sentry/tracing mandatory + add tests #2841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 24, 2020
Merged

ref(gatsby): Make @sentry/tracing mandatory + add tests #2841

merged 8 commits into from
Aug 24, 2020

Conversation

AbhiPrasad
Copy link
Member
@AbhiPrasad AbhiPrasad commented Aug 24, 2020 •
edited
Loading

A couple of changes here.

  1. Add tests for gatsby-browser and gatsby-node 😎
--------------------|----------|----------|----------|----------|-------------------|
File                |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
--------------------|----------|----------|----------|----------|-------------------|
All files           |      100 |    92.59 |      100 |      100 |                   |
 gatsby             |      100 |    92.59 |      100 |      100 |                   |
  gatsby-browser.js |      100 |    86.67 |      100 |      100 |             19,34 |
  gatsby-node.js    |      100 |      100 |      100 |      100 |                   |
 gatsby/src         |      100 |      100 |      100 |      100 |                   |
  index.ts          |      100 |      100 |      100 |      100 |                   |
--------------------|----------|----------|----------|----------|-------------------|

  1. Refactor gatsby to add @sentry/tracing by default.

  2. Remove the require.ensure call inside the onClientEntry, as that was causing a delay in initialization. This fixes @sentry/gatsby fails to catch error triggered from useEffect #2785.

Tested with unit tests and by checking in develop docs.

@AbhiPrasad AbhiPrasad requested a review from HazAT August 24, 2020 13:14
HazAT
HazAT approved these changes Aug 24, 2020
View reviewed changes
Copy link
Member
@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@github-actions
Copy link
Contributor
github-actions bot commented Aug 24, 2020 •
edited
Loading

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 17.67 KB (-0.01% 🔽)
@sentry/browser - Webpack 18.46 KB (0%)
@sentry/react - Webpack 18.46 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 22.77 KB (-0.01% 🔽)

@AbhiPrasad AbhiPrasad mentioned this pull request Aug 24, 2020
Closed
9 tasks
@AbhiPrasad AbhiPrasad force-pushed the abhi/gatsby-refactor branch from e284339 to 6633e29 Compare August 24, 2020 14:40
@AbhiPrasad AbhiPrasad merged commit f070384 into master Aug 24, 2020
@AbhiPrasad AbhiPrasad deleted the abhi/gatsby-refactor branch August 24, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT HazAT approved these changes

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@sentry/gatsby fails to catch error triggered from useEffect
2 participants
@AbhiPrasad @HazAT
0