E52F fix(nuxt): Added top-level fallback exports by logaretm · Pull Request #18083 · getsentry/sentry-javascript · GitHub
[go: up one dir, main page]
Skip to content

fix(nuxt): Added top-level fallback exports #18083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2025
Merged

fix(nuxt): Added top-level fallback exports #18083

merged 2 commits into from
Nov 3, 2025

Conversation

@logaretm
Copy link
Collaborator
@logaretm logaretm commented Nov 3, 2025 •
edited
Loading

It seems that in some cases where an environment in Vite is set to something other than node or browser, it won't be able to figure out the correct import paths.

This PR ensures that when Vite (or other tools) can't determine the environment from "browser" or "node" conditions alone, then it falls back to the server bundle similar to what we do in Next.js.

In the issue's case it was set to nuxt or rather vitest-environment-nuxt which doesn't seem like a pattern to account for.

closes #18070

@linear
Copy link
linear bot commented Nov 3, 2025

JS-1104 vitest + nuxt | `Failed to resolve entry for package "@sentry/nuxt"`

cursor[bot]

This comment was marked as outdated.

Sign in to view

@logaretm logaretm force-pushed the awad/js-1104-vitest-nuxt-failed-to-resolve-entry branch from c3165dd to 66817b6 Compare November 3, 2025 12:45
cursor[bot]

This comment was marked as outdated.

Sign in to view

@s1gr1d s1gr1d changed the title fix(nuxt): added top-level fallback exports fix(nuxt): Added top-level fallback exports Nov 3, 2025
@logaretm logaretm merged commit b57ade1 into develop Nov 3, 2025
48 checks passed
@logaretm logaretm deleted the awad/js-1104-vitest-nuxt-failed-to-resolve-entry branch November 3, 2025 14:58
@github-actions github-actions bot mentioned this pull request Nov 5, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@s1gr1d s1gr1d s1gr1d approved these changes

@andreiborza andreiborza Awaiting requested review from andreiborza

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

vitest/browser + nuxt | Failed to resolve entry for package "@sentry/nuxt"

3 participants

@logaretm @s1gr1d
0