fix(browser-utils): cache element names for INP #18052
Merged
+113
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
s1gr1d
reviewed
Oct 29, 2025
| } | ||
|
|
||
| const elementName = htmlTreeAsString(target); | ||
| const timestamp = Math.round(event.timeStamp); |
There was a problem hiding this comment.
just a question: why is it rounded here?
There was a problem hiding this comment.
The event.timeStamp is a DOMHighResTimeStamp, so to increase the chances of a hit on the map I'm rounding it because the decimals might throw it off.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
5682e8d to
3e68970
Compare
s1gr1d
approved these changes
Oct 30, 2025
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
7d1349a to
6d8754a
Compare
6d8754a to
c6f3d50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes interaction elements showing up as
<unknown>in case they get removed from the DOM.The implementation adds global listeners to listen for interaction events and store the most recent 50 events in an LRU-like cache then matches that with the performance entry timestamp.