8000 fix: Add type/value to exception in case of no error by HazAT · Pull Request #1803 · getsentry/sentry-javascript · GitHub
[go: up one dir, main page]
Skip to content

fix: Add type/value to exception in case of no error #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 9, 2019
Merged

fix: Add type/value to exception in case of no error #1803

merged 4 commits into from
Jan 9, 2019

Conversation

HazAT
Copy link
Member
@HazAT HazAT commented Dec 19, 2018

No description provided.

@HazAT HazAT self-assigned this Dec 19, 2018
@HazAT HazAT requested a review from kamilogorek as a code owner December 19, 2018 13:51
@HazAT HazAT requested review from mitsuhiko and untitaker December 19, 2018 13:51
@getsentry-bot
Copy link
Contributor
getsentry-bot commented Dec 19, 2018 •
edited
Loading
Fails
🚫

TSLint failed: @sentry/browser

  • ERROR: /home/travis/build/getsentry/sentry-javascript/packages/browser/src/integrations/trycatch.ts[213, 1]: Documentation must exist for functions.
Messages
📖 @sentry/browser gzip'ed minified size: 22.1338 kB

Generated by 🚫 dangerJS

kamilogorek
kamilogorek reviewed Jan 9, 2019
View reviewed changes
packages/browser/test/integration/test.js Outdated
assert.isAtLeast(sentryData.stacktrace.frames.length, 1);
assert.isAtMost(sentryData.stacktrace.frames.length, 3);
assert.isAtLeast(sentryData.exception.values[0].stacktrace.frames.length, 1);
assert.isAtMost(sentryData.exception.values[0].stacktrace.frames.length, 30);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

30? o_O

@HazAT HazAT force-pushed the fix/add-exception-type-value branch from fef96f9 to f918785 Compare January 9, 2019 08:28
@kamilogorek
Copy link
Contributor

:ok

@HazAT HazAT merged commit 44ce010 into master Jan 9, 2019
@HazAT HazAT deleted the fix/add-exception-type-value branch January 9, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilogorek kamilogorek kamilogorek left review comments

@untitaker untitaker untitaker approved these changes

@mitsuhiko mitsuhiko Awaiting requested review from mitsuhiko

Assignees

@HazAT HazAT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HazAT @getsentry-bot @kamilogorek @untitaker
0