feat(replay): export compression worker for bundling #16794
+68
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chargome
requested changes
Jul 3, 2025
There was a problem hiding this comment.
@Spice-King thanks for contributing!
Please limit the subpath export to the @sentry/replay-internal package and remove the @sentry/browser part for now. We can then iterate from here, but subpath exports from browser can be a bit risky to handle on our side.
|
Alright, dropping e451d37 and rebasing to develop now. |
e515834 to
0570522
Compare
0570522 to
ce86312
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16739. This is broken up into three commits, each to solve a given fragment of the over all issue I wrote up.
Of note, e451d37 was a bit of a compromise. While I could then reexport the worker in every single sub package that imports
@sentry/browser, it felt too dirty and I have bashed my head on trying to make a less invasive way to export it in those sub packages. Perfect is the enemy of good enough, and this does at least work and avoids people poking@sentry-internal/replayat the very least.e515834 is more a creature comfort since Vite's recommended way creates a URL object to load it, and it's not like it's being handled in any way more than grabbing a default.
Both of those commits could be ejected from this PR, if you'd rather not have them or they'd be better suited to a separate PR. A follow PR to the docs repo is something I'll cook up if/when this is merged, unless someone has a strong opinion on how to write it.
yarn lint) & (yarn test).