8000 fix(node): Revert to using upstream `@fastify/otel` instrumentation by andreiborza · Pull Request #16320 · getsentry/sentry-javascript · GitHub
[go: up one dir, main page]
Skip to content

fix(node): Revert to using upstream @fastify/otel instrumentation #16320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(node): Revert to using upstream @fastify/otel instrumentation #16320

wants to merge 1 commit into from

Conversation

andreiborza
Copy link
Member

With #16256 we switched from upstream @fastify/otel to a Otel v1 downgraded fork to ensure dependencies are aligned with our node sdk.

This PR will re-introduce a warning about unmet dependencies #16245 for the time being.

@andreiborza
fix(node): Revert to using upstream @fastify/otel instrumentation
1a76422 
With #16256 we switched from upstream `@fastify/otel` to a Otel v1 downgraded
fork to ensure dependencies are aligned with our node sdk.

This PR will re-introduce a warning about unmet dependencies #16245 for the time
being.
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.04 kB - -
@sentry/browser - with treeshaking flags 23.7 kB - -
@sentry/browser (incl. Tracing) 38.46 kB - -
@sentry/browser (incl. Tracing, Replay) 76.58 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 69.61 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 81.35 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 93.46 kB - -
@sentry/browser (incl. Feedback) 40.83 kB - -
@sentry/browser (incl. sendFeedback) 28.79 kB - -
@sentry/browser (incl. FeedbackAsync) 33.66 kB - -
@sentry/react 25.86 kB - -
@sentry/react (incl. Tracing) 40.48 kB - -
@sentry/vue 28.44 kB - -
@sentry/vue (incl. Tracing) 40.28 kB - -
@sentry/svelte 24.07 kB - -
CDN Bundle 25.25 kB - -
CDN Bundle (incl. Tracing) 38.54 kB - -
CDN Bundle (incl. Tracing, Replay) 74.32 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 79.77 kB - -
CDN Bundle - uncompressed 73.68 kB - -
CDN Bundle (incl. Tracing) - uncompressed 114.08 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 228.05 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 240.87 kB - -
@sentry/nextjs (client) 42.08 kB - -
@sentry/sveltekit (client) 38.95 kB - -
@sentry/node 155.36 kB -1.77% -2.8 kB 🔽
@sentry/node - without tracing 98.07 kB - -
@sentry/aws-serverless 123.41 kB - -

View base workflow run

@andreiborza
Copy link
Member Author

Closing this after some discussions in the team as it would just replace one problem with another one. We'll wait for the fork being vendored in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea Awaiting requested review from mydea

@onurtemizkan onurtemizkan Awaiting requested review from onurtemizkan

@chargome chargome Awaiting requested review from chargome

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andreiborza
0