8000 feat(node): Rewrite absolute stackframes by default by mydea · Pull Request #16307 · getsentry/sentry-javascript · GitHub
[go: up one dir, main page]
Skip to content

feat(node): Rewrite absolute stackframes by default #16307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

feat(node): Rewrite absolute stackframes by default #16307

wants to merge 7 commits into from

Conversation

mydea
Copy link
Member
@mydea mydea commented May 15, 2025 •
edited
Loading

Let's see if this makes sense...

This is specced here: https://develop.sentry.dev/sdk/data-model/event-payloads/stack 8000 trace/#frame-attributes

filename
The path to the source file relative to the project root directory.

Additionally, I am adding the abs_path which is the filename before we preprocessed it here 🤔 not sure if we even need this/how relevant this is, maybe we can skip this step.

Questions:

  1. Should filename have a leading / or not 🤔
  2. Do we need/want abs_path 🤔

@mydea mydea self-assigned this May 15, 2025
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented May 15, 2025 •
edited
Loading

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.04 kB - -
@sentry/browser - with treeshaking flags 23.7 kB - -
@sentry/browser (incl. Tracing) 38.46 kB - -
@sentry/browser (incl. Tracing, Replay) 76.58 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 69.61 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 81.35 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 93.46 kB - -
@sentry/browser (incl. Feedback) 40.83 kB - -
@sentry/browser (incl. sendFeedback) 28.79 kB - -
@sentry/browser (incl. FeedbackAsync) 33.66 kB - -
@sentry/react 25.86 kB - -
@sentry/react (incl. Tracing) 40.48 kB - -
@sentry/vue 28.44 kB - -
@sentry/vue (incl. Tracing) 40.28 kB - -
@sentry/svelte 24.07 kB - -
CDN Bundle 25.25 kB - -
CDN Bundle (incl. Tracing) 38.54 kB - -
CDN Bundle (incl. Tracing, Replay) 74.32 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 79.77 kB - -
CDN Bundle - uncompressed 73.68 kB - -
CDN Bundle (incl. Tracing) - uncompressed 114.08 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 228.05 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 240.87 kB - -
@sentry/nextjs (client) 42.09 kB +0.03% +9 B 🔺
@sentry/sveltekit (client) 38.95 kB - -
@sentry/node 158.78 kB +0.4% +627 B 🔺
@sentry/node - without tracing 98.71 kB +0.66% +641 B 🔺
@sentry/aws-serverless 124.08 kB +0.54% +663 B 🔺

View base workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mydea
0