8000 fix: Fixes stack trace order + es5 tracekit + basebackend impl by HazAT · Pull Request #1512 · getsentry/sentry-javascript · GitHub
[go: up one dir, main page]
Skip to content

fix: Fixes stack trace order + es5 tracekit + basebackend impl #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 6, 2018
Merged

fix: Fixes stack trace order + es5 tracekit + basebackend impl #1512

merged 2 commits into from
Sep 6, 2018

Conversation

HazAT
Copy link
Member
@HazAT HazAT commented Sep 5, 2018 •
edited
Loading

Fixes #1513

@HazAT HazAT requested a review from kamilogorek as a code owner September 5, 2018 14:58
@HazAT HazAT mentioned this pull request Sep 5, 2018
Merged
@codecov-io
Copy link
codecov-io commented Sep 6, 2018 •
edited
Loading

Codecov Report

Merging #1512 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1512   +/-   ##
=======================================
  Coverage   73.08%   73.08%           
=======================================
  Files          44       44           
  Lines        1330     1330           
  Branches      250      250           
=======================================
  Hits          972      972           
  Misses        350      350           
  Partials        8        8
Impacted Files Coverage Δ
packages/node/src/parsers.ts 83.87% <100%> (ø) ⬆️
packages/core/src/basebackend.ts 85% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebd4fff...ef2e080. Read the comment docs.

@HazAT HazAT mentioned this pull request Sep 6, 2018
Closed
8 tasks
@HazAT HazAT merged commit 755c1e6 into master Sep 6, 2018
@HazAT HazAT deleted the fix/broken-stuff branch September 6, 2018 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilogorek kamilogorek kamilogorek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HazAT @codecov-io @kamilogorek
0