test(e2e): Add nextjs-13 e2e test app
#13154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(The old Next.js integration tests flaking on this PR is hilariously ironic) |
lforst
commented
Aug 1, 2024
| @@ -22,7 +22,7 @@ export function getPlaywrightConfig( | |||
| const config: PlaywrightTestConfig = { | |||
| testDir: './tests', | |||
| /* Maximum time one test can run for. */ | |||
| timeout: 150_000, | |||
There was a problem hiding this comment.
We used to have a very long timeout here because we used to poll for events on sentry and that could take a while. Nowadays the tests that poll sentry have their own playwright configs with long timeouts so we can lessen the timeout here.
chargome
reviewed
Aug 1, 2024
| if (typeof window !== 'undefined' && typeof window.onerror === 'function') { | ||
| // Lovely oldschool browsers syntax with 5 arguments <3 | ||
| // @ts-expect-error | ||
| window.onerror(null, null, null, null, new Error('Crashed')); |
There was a problem hiding this comment.
@kamilogorek it lives on
lforst
added a commit
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Next.js 13 e2e test app with all the tests we have in our current Next.js integration tests.
Ref #13086