8000 feat(core): Deprecate `Span.spanRecorder` by Lms24 · Pull Request #10199 · getsentry/sentry-javascript · GitHub
[go: up one dir, main page]
Skip to content

feat(core): Deprecate Span.spanRecorder #10199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2024
Merged

feat(core): Deprecate Span.spanRecorder #10199

merged 1 commit into from
Jan 16, 2024

Conversation

Lms24
Copy link
Member
@Lms24 Lms24 commented Jan 16, 2024 •
edited
Loading

This PR deprecates the spanRecorder field on the Span class. For now there's no replacement yet. I'm not entirely sure how we're going to keep track of spans within the SDK. #9972 shows an alternative for IdleSpan which no longer seems to rely on the spanRecorder. Another possibility might be to make the recorder private which might be enough, too.

Anyhow, we should deprecate the field in any case as it's not meant to be user facing and of course also doesn't exist on the Otel Span interface.

ref #10184

@Lms24 Lms24 requested a review from mydea January 16, 2024 13:47
@Lms24 Lms24 mentioned this pull request Jan 16, 2024
Closed
@Lms24 Lms24 self-assigned this Jan 16, 2024
@Lms24 Lms24 force-pushed the lms/feat-core-deprecate-span-spanrecorder branch from 9b074a7 to 0ccc4b9 Compare January 16, 2024 14:52
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jan 16, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.27 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.59 KB (+0.09% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.23 KB (+0.09% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.62 KB (+0.18% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.13 KB (0%)
@sentry/browser - Webpack (gzipped) 22.48 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 74.89 KB (+0.08% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 66.52 KB (+0.08% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.36 KB (+0.16% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.13 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 209.56 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 97.61 KB (-0.07% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 72.23 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 35.4 KB (+0.16% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 68.98 KB (+0.11% 🔺)
@sentry/react - Webpack (gzipped) 22.52 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.61 KB (+0.07% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 49.73 KB (+0.12% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.11 KB (0%)

@Lms24 Lms24 force-pushed the lms/feat-core-deprecate-span-spanrecorder branch from a1ffee4 to 8a8dee1 Compare January 16, 2024 16:31
@Lms24 Lms24 merged commit 66333e6 into develop Jan 16, 2024
@Lms24 Lms24 deleted the lms/feat-core-deprecate-span-spanrecorder branch January 16, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

Assignees

@Lms24 Lms24

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lms24 @mydea
0