8000 angular package - HttpErrorResponse is always null in defaultExtractor · Issue #2960 · getsentry/sentry-javascript · GitHub
[go: up one dir, main page]
Skip to content

angular package - HttpErrorResponse is always null in defaultExtractor #2960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JustDoItSascha opened this issue Oct 8, 2020 · 1 comment
Closed

angular package - HttpErrorResponse is always null in defaultExtractor #2960

JustDoItSascha opened this issue Oct 8, 2020 · 1 comment

Comments

@JustDoItSascha
Copy link
Contributor

Package + Version

  • [5.25.0] @sentry/angular

Description

In the packages/angular/src/errorhandler.ts#105 you do this: if (error instanceof HttpErrorResponse) {

But this line will always be false, because in your package.json you added @angular/common as dependency instead of peerDependency. This causes the issue that error is always an instance of the HttpErrorResponse of the main project but not an instance of the HttpErrorResponse sitting in the node_modules directory of your library.

This leads to the bug, that every HttpErrorResponse of Angular results in this in the sentry dashboard:

<unknown>
error
Handled unknown error

It can be solved by making at least the @angular/common dependency to a peerDependency.
JustDoItSascha added a commit to JustDoItSascha/sentry-javascript that referenced this issue Oct 8, 2020
@JustDoItSascha
Make @angular/common a peerDependency instead of dependency
066eecb 
Solves getsentry#2960
@JustDoItSascha JustDoItSascha mentioned this issue Oct 8, 2020
Merged
2 tasks
@antgel
Copy link
antgel commented Aug 9, 2021

Can this be closed as it was merged last October?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@antgel @HazAT @JustDoItSascha @AbhiPrasad
0