8000 `inboundFiltersIntegration` logs error for native events · Issue #11462 · getsentry/sentry-javascript · GitHub
[go: up one dir, main page]
Skip to content

inboundFiltersIntegration logs error for native events #11462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
timfish opened this issue Apr 6, 2024 · 1 comment · Fixed by #11473
Closed

inboundFiltersIntegration logs error for native events #11462

timfish opened this issue Apr 6, 2024 · 1 comment · Fixed by #11473

Comments

@timfish
Copy link
Collaborator
timfish commented Apr 6, 2024 •
edited
Loading

Problem Statement

This error log message is triggered for any event that has no message or exception name which includes all native events from the Electron SDK

sentry-javascript/packages/core/src/integrations/inboundfilters.ts

Lines 158 to 160 in 6a76525

if (DEBUG_BUILD && possibleMessages.length === 0) {
logger.error(`Could not extract message for event ${getEventDescription(event)}`);
}

Solution Brainstorm

I guess if we need to log this at all it should be a regular log rather than warn or error.
@timfish timfish changed the title inboundFiltersIntegration logs error native events inboundFiltersIntegration logs error for native events Apr 6, 2024
@mydea
Copy link
Member
mydea commented Apr 8, 2024

I'm fine with removing that log overall!

@timfish timfish mentioned this issue Apr 8, 2024
Merged
AbhiPrasad pushed a commit that referenced this issue Apr 8, 2024
@timfish
fix(core): Don't log error from Inbound Filters integration (#11473)
4239d2f 
Closes #11462
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this issue Apr 19, 2024
@timfish @cadesalaberry
fix(core): Don't log error from Inbound Filters integration (getsentr…
334b73c 
…y#11473)

Closes getsentry#11462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core): Don't log error from Inbound Filters integration getsentry/sentry-javascript
2 participants
@timfish @mydea
0