8000 docs(elixir): Only recommend Sentry.PlugCapture for Cowboy applications by martosaur · Pull Request #13890 · getsentry/sentry-docs · GitHub
[go: up one dir, main page]
Skip to content

docs(elixir): Only recommend Sentry.PlugCapture for Cowboy applications #13890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs(elixir): Only recommend Sentry.PlugCapture for Cowboy applications #13890

wants to merge 1 commit into from
+21 −5

Conversation

martosaur
Copy link

DESCRIBE YOUR PR

Updating Elixir's Plug and Phoenix guide to reflect changes made in getsentry/sentry-elixir#895
In short, PlugCapture makes a lot of sense for Cowboy applications but isn't needed for apps using new Bandit webserver.

IS YOUR CHANGE URGENT?

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

I believe it's best to go live the same time as next Sentry package version

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel Vercel
Copy link
vercel bot commented May 30, 2025

@martosaur is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@martosaur martosaur marked this pull request as ready for review May 30, 2025 18:17
@martosaur
Copy link
Author

@whatyouhide 👁️

whatyouhide
whatyouhide approved these changes May 31, 2025
View reviewed changes
Copy link
Collaborator
@whatyouhide whatyouhide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@martosaur martosaur force-pushed the am-discourage-plug-capture branch from 251e0d1 to f8a8258 Compare May 31, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whatyouhide whatyouhide whatyouhide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martosaur @whatyouhide
0