8000 Update middleware.ts integrations by masinette · Pull Request #13888 · getsentry/sentry-docs · GitHub
[go: up one dir, main page]
Skip to content

Update middleware.ts integrations #13888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update middleware.ts integrations #13888

wants to merge 5 commits into from

Conversation

masinette
Copy link
Member

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel Vercel
Copy link
vercel bot commented May 30, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2025 9:08pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2025 9:08pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2025 9:08pm

@codecov Codecov
Copy link
codecov bot commented May 30, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 2.77kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.22MB -9 bytes (-0.0%) ⬇️
sentry-docs-edge-server-array-push 378.9kB 72 bytes (0.02%) ⬆️
sentry-docs-client-array-push 9.77MB 2.71kB (0.03%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/media/cd914ecf9c9071d5-*.p.woff2 (New) 36.44kB 36.44kB 100.0% 🚀
static/media/0a86735c6520d94f-*.p.woff2 (New) 35.32kB 35.32kB 100.0% 🚀
static/media/4fca85807f6c09f6-*.woff2 (New) 32.6kB 32.6kB 100.0% 🚀
static/media/d695df15e3ff125c-*.woff2 (New) 32.58kB 32.58kB 100.0% 🚀
static/media/acdf4f392b58827a-*.woff2 (New) 21.13kB 21.13kB 100.0% 🚀
static/media/501d9eeee6e2b0cc-*.woff2 (New) 19.41kB 19.41kB 100.0% 🚀
static/media/e136059a869f199b-*.woff2 (New) 16.46kB 16.46kB 100.0% 🚀
static/media/c1b11e140b58cf5a-*.woff2 (New) 15.11kB 15.11kB 100.0% 🚀
static/media/434c0c74b95acb46-*.woff2 (New) 13.66kB 13.66kB 100.0% 🚀
static/media/60181e10ad16e354-*.woff2 (New) 12.29kB 12.29kB 100.0% 🚀
static/media/a72efd2c2476ebb2-*.woff2 (New) 9.7kB 9.7kB 100.0% 🚀
static/media/9d7436bc73437f75-*.woff2 (New) 9.36kB 9.36kB 100.0% 🚀
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/KblqpEhd7meFInYJXhTLV/_buildManifest.js (New) 616 bytes 616 bytes 100.0% 🚀
static/KblqpEhd7meFInYJXhTLV/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/media/b9378c7268e717c1-*.p.woff2 (Deleted) -36.52kB 0 bytes -100.0% 🗑️
static/media/c22ccc5eb58b83e1-*.p.woff2 (Deleted) -35.32kB 0 bytes -100.0% 🗑️
static/media/f1fcc5ff05fc0d5e-*.woff2 (Deleted) -32.42kB 0 bytes -100.0% 🗑️
static/media/356abdd51b933898-*.woff2 (Deleted) -32.26kB 0 bytes -100.0% 🗑️
static/media/8be5568353d67f1e-*.woff2 (Deleted) -20.82kB 0 bytes -100.0% 🗑️
static/media/0596140cb8d9223a-*.woff2 (Deleted) -19.09kB 0 bytes -100.0% 🗑️
static/media/6551d72ebeeac6a7-*.woff2 (Deleted) -16.3kB 0 bytes -100.0% 🗑️
static/media/341baa6ce7a16e81-*.woff2 (Deleted) -15.08kB 0 bytes -100.0% 🗑️
static/media/2a54da80dbfac484-*.woff2 (Deleted) -13.62kB 0 bytes -100.0% 🗑️
static/media/1a4dd1d7cd3232ea-*.woff2 (Deleted) -12.29kB 0 bytes -100.0% 🗑️
static/media/ee8ee7e184152fe5-*.woff2 (Deleted) -8.94kB 0 bytes -100.0% 🗑️
static/media/d70c23d6fe66d464-*.woff2 (Deleted) -8.69kB 0 bytes -100.0% 🗑️
static/1AwGq5Fi388Q0h2fkZpUj/_buildManifest.js (Deleted) -616 bytes 0 bytes -100.0% 🗑️
static/1AwGq5Fi388Q0h2fkZpUj/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
view changes for bundle: sentry-docs-edge-server-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
src/middleware.js 72 bytes 206.63kB 0.03%

@coolguyzone
Copy link
Contributor

Hey @masinette could you provide some context here? Why are we moving these redirects around in the file? Thanks!

@masinette
Copy link
Member Author

@coolguyzone it looks like I added them to wrong section originally. This is a correction

@masinette masinette enabled auto-merge (squash) June 4, 2025 17:21
cursor[bot]
cursor bot reviewed Jul 18, 2025
View reviewed changes
Copy link
@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Redirect Path Error Causes 404

The redirect for /organization/integrations/elba/ was incorrectly modified to /organization/integrations/elba-alpha/ when moved from DEVELOPER_DOCS_REDIRECTS to USER_DOCS_REDIRECTS. This change was unintended, as the PR aimed to only move redirects, not alter their paths. Consequently, existing links to the original /organization/integrations/elba/ URL will now result in 404 errors.

src/middleware.ts#L222-L225

sentry-docs/src/middleware.ts

Lines 222 to 225 in 703cee1

{
from: '/organization/integrations/elba-alpha/',
to: '/organization/integrations/compliance/elba-alpha/',
},

Fix in Cursor • Fix in Web

Bug: Removed Redirects Cause User Errors

The commit removes several functional redirects from DEVELOPER_DOCS_REDIRECTS without replacement, which will cause 404 errors for users. The affected paths include /feature-flags/options-backed-features/, /sdk/metrics/, /backend/feature-flags/options-backed-features/, and /api-server/application-domains/feature-flags/options-backed-features/.

src/middleware.ts#L3650-L3668

sentry-docs/src/middleware.ts

Lines 3650 to 3668 in 703cee1

},
{
from: '/options/',
to: '/backend/options/',
},
{
from: '/sdk/features/data-handling/',
to: '/sdk/expected-features/data-handling/',
},
{
from: '/sdk/craft-quick-start/',
to: '/sdk/processes/releases/',
},
{
from: '/sdk/check-ins/',
to: '/sdk/telemetry/check-ins/',
},
{
from: '/sdk/profiles/',

src/middleware.ts#L3860-L3868

sentry-docs/src/middleware.ts

Lines 3860 to 3868 in 703cee1

},
{
from: '/backend/options/',
to: '/backend/application-domains/options/',
},
{
from: '/api-server/application-domains/options/',
to: '/develop/application-domains/options/',
},

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@codyde codyde Awaiting requested review from codyde

@sentaur-athena sentaur-athena Awaiting requested review from sentaur-athena

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masinette @coolguyzone
0