8000 feat(dynamic sampling) : Use beta version of JS SDK with `tracestate` behavior by lobsterkatie · Pull Request #24177 · getsentry/sentry · GitHub
[go: up one dir, main page]

Skip to content

feat(dynamic sampling) : Use beta version of JS SDK with tracestate behavior #24177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2021

Conversation

lobsterkatie
Copy link
Member

In concert with https://github.com/getsentry/getsentry/pull/5192, this allows us to dogfood the use of the tracestate header to pass data necessary for server-side dynamic sampling. Specifically, it moves us to using a beta version of the JS SDK which implements three new behaviors:

  • consumption and parsing of tracestate headers on incoming HTTP requests
  • propagation of received (if applicable) or newly-generated tracestate headers in outgoing HTTP requests
  • inclusion of the tracestate data in the envelope header of all transactions in the trace

More information can be found in the kmclb-dynamic-sampling-data-in-envelopes branch of the JS SDK repo.

@lobsterkatie lobsterkatie requested a review from a team as a code owner March 2, 2021 17:44
@lobsterkatie lobsterkatie requested review from jan-auer and RaduW March 2, 2021 17:45
@github-actions
Copy link
Contributor
github-actions bot commented Mar 2, 2021

size-limit report

Path Base Size (e365a6e) Current Size Change
public/app.js 319.77 KB 320.02 KB +0.08% 🔺
public/vendor.js 630.7 KB 643.83 KB +2.09% 🔺
public/sentry.css 25.77 KB 25.77 KB 0%

@lobsterkatie lobsterkatie marked this pull request as draft March 2, 2021 18:19
@lobsterkatie lobsterkatie merged commit 915bd85 into master Mar 3, 2021
@lobsterkatie lobsterkatie deleted the kmclb-js-sdk-6.3.0-beta.0 branch March 3, 2021 19:12
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0