8000 feat: Use sentry-javascript 5.25.0-beta.1 with sessions support by kamilogorek · Pull Request #20885 · getsentry/sentry · GitHub
[go: up one dir, main page]
Skip to content

feat: Use sentry-javascript 5.25.0-beta.1 with sessions support #20885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 22, 2020
Merged

feat: Use sentry-javascript 5.25.0-beta.1 with sessions support #20885

merged 2 commits into from
Sep 22, 2020

Conversation

kamilogorek
Copy link
Contributor

@kamilogorek kamilogorek requested a review from HazAT September 21, 2020 15:56
@kamilogorek kamilogorek requested a review from a team as a code owner September 21, 2020 15:56
@github-actions
Copy link
Contributor
github-actions bot commented Sep 21, 2020 •
edited
Loading

size-limit report

Path Size
public/app.js 235.1 KB (+0.01% 🔺)
public/vendor.js 447.8 KB (+0.75% 🔺)

@dashed
Copy link
Member
dashed commented Sep 21, 2020

@kamilogorek this will break getsentry development environments unless this is updated

sentry/build-utils/sentry-instrumentation.js

Lines 28 to 35 in 72645fa

// Only run if SENTRY_INSTRUMENTATION` is set or when in travis, only in the javascript suite that runs webpack
if (!SENTRY_INSTRUMENTATION) {
return;
}
this.initialBuild = false;
this.Sentry = require('@sentry/node');
require('@sentry/apm'); // This is required to patch Sentry

@HazAT HazAT merged commit ed9cb6e into master Sep 22, 2020
@HazAT HazAT deleted the js-sessions-beta branch September 22, 2020 08:19
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@billyvg billyvg billyvg approved these changes

@dashed dashed dashed approved these changes

@HazAT HazAT Awaiting requested review from HazAT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kamilogorek @dashed @billyvg @HazAT
0