fix(preprod): Add NOT_STARTED state to frontend #107145
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| PROCESSING = 1, | ||
| COMPLETED = 2, | ||
| FAILED = 3, | ||
| NOT_RAN = 4, |
Contributor
There was a problem hiding this comment.
Missing type interface for new NOT_RAN enum state
Medium Severity
The new NOT_RAN = 4 enum value is added to BuildDetailsSizeAnalysisState, but the corresponding type interface (e.g., BuildDetailsSizeInfoNotRan) is missing, and the BuildDetailsSizeInfo discriminated union type doesn't include this new state. If the API returns a response with state: NOT_RAN, TypeScript's type narrowing won't work correctly and the type will effectively be never, leading to potential runtime issues when accessing properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.