Minor notes

getnamo · Jun 6, 2024 · b305eed · b305eed
1 parent 8e669a6
commit b305eed
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 7 deletions.
diff --git a/Source/Blu/Private/BluEye.cpp b/Source/Blu/Private/BluEye.cpp
@@ -192,6 +192,7 @@ void UBluEye::TextureUpdate(const void *Buffer, FUpdateTextureRegion2D *UpdateRe
 		{
 			for (uint32 RegionIndex = 0; RegionIndex < RegionData->NumRegions; RegionIndex++)
 			{
+				//NB: FORCEINLINE void RHIUpdateTexture2D(FRHITexture2D* Texture, uint32 MipIndex, const struct FUpdateTextureRegion2D& UpdateRegion, uint32 SourcePitch, const uint8* SourceData)
 				RHIUpdateTexture2D(RegionData->Texture2DResource->TextureRHI->GetTexture2D(), 0, RegionData->Regions[RegionIndex], RegionData->SrcPitch, 
 					RegionData->SrcData.GetData()
 					+ RegionData->Regions[RegionIndex].SrcY * RegionData->SrcPitch
@@ -652,7 +653,13 @@ void UBluEye::SpawnTickEventLoopIfNeeded()
 				{
 					UE_LOG(LogTemp, Log, TEXT("Delta: %1.2f"), DeltaTime);
 				}
-				BluManager::DoBluMessageLoop();
+
+				//NB: this wrapper doesn't crash, but will fail to render
+				//Async(EAsyncExecution::ThreadPool, [this] 
+				//{
+					BluManager::DoBluMessageLoop();
+				//});
+
 			}
 
 			return true;

diff --git a/Source/Blu/Private/RenderHandler.cpp b/Source/Blu/Private/RenderHandler.cpp
@@ -18,15 +18,15 @@ void RenderHandler::OnPaint(CefRefPtr<CefBrowser> Browser, PaintElementType Type
 {
 	FUpdateTextureRegion2D *UpdateRegions = static_cast<FUpdateTextureRegion2D*>(FMemory::Malloc(sizeof(FUpdateTextureRegion2D) * DirtyRects.size()));
 
-	int Current = 0;
+	int RegionIndex = 0;
 	for (auto DirtyRect : DirtyRects)
 	{
-		UpdateRegions[Current].DestX = UpdateRegions[Current].SrcX = DirtyRect.x;
-		UpdateRegions[Current].DestY = UpdateRegions[Current].SrcY = DirtyRect.y;
-		UpdateRegions[Current].Height = DirtyRect.height;
-		UpdateRegions[Current].Width = DirtyRect.width;
+		UpdateRegions[RegionIndex].DestX = UpdateRegions[RegionIndex].SrcX = DirtyRect.x;
+		UpdateRegions[RegionIndex].DestY = UpdateRegions[RegionIndex].SrcY = DirtyRect.y;
+		UpdateRegions[RegionIndex].Height = DirtyRect.height;
+		UpdateRegions[RegionIndex].Width = DirtyRect.width;
 
-		Current++;
+		RegionIndex++;
 	}
 
 	// Trigger our parent UIs Texture to update