8000 Use numbered administrative level instead of named one by giosh94mhz · Pull Request #398 · geocoder-php/Geocoder · GitHub
[go: up one dir, main page]
Skip to content

Use numbered administrative level instead of named one #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Feb 13, 2015
Merged

Use numbered administrative level instead of named one #398

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c888d7c
GeoIP2 results use underscore case
giosh94mhz Jan 12, 2015
b280be5
Fix Geocoder type hint
giosh94mhz Jan 16, 2015
10bd7c3
Add AddressFactory type hint
giosh94mhz Jan 19, 2015
12d59a7
AddressCollection::first type hint
giosh94mhz Jan 19, 2015
fa52e57
ProviderAggregator always return AddressCollection
giosh94mhz Jan 20, 2015
3678742
Remove useless @ from GeonamesTest
giosh94mhz Jan 20, 2015
e918322
AddressCollection contructor docblock
giosh94mhz Jan 20, 2015
204a3fd
Add AddressCollection::has predicate
giosh94mhz Jan 29, 2015
813b270
TomTom provider: handle "Developer Inactive" error
giosh94mhz Jan 27, 2015
58e5def
Replace County and Region with AdminLevels
giosh94mhz Jan 12, 2015
012cc59
Fix localhost default tests
giosh94mhz Jan 30, 2015
32f4544
Avoid null object in StringFormatter
giosh94mhz Feb 5, 2015
6ae5a6d
OpenStreetMap fix postal code and tests
giosh94mhz Feb 1, 2015
9366ff1
Fix Gpx dumper for adminLevels
giosh94mhz Feb 5, 2015
34284c2
Http cache hashing doesn't depend from apikey
giosh94mhz Feb 1, 2015
990ab98
Yandex Provider support 2 admin levels (+minor fixes)
giosh94mhz Feb 1, 2015
11ccbc4
Minor syntax fixes
giosh94mhz Feb 13, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
OpenStreetMap fix postal code and tests
  • Loading branch information
@giosh94mhz
giosh94mhz committed Feb 11, 2015
commit 6ae5a6d8b7d7696ef814d316e5761c14ce2b2736
7 changes: 6 additions & 1 deletion src/Geocoder/Provider/Nominatim.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,15 @@ private function xmlResultToArray(\DOMElement $resultNode, \DOMElement $addressN
}
}

// get the first postal-code when there are many
$postalCode = current(explode(';',
$this->getNodeValue($addressNode->getElementsByTagName('postcode'))
));

$result = [
'latitude' => $resultNode->getAttribute('lat'),
'longitude' => $resultNode->getAttribute('lon'),
'postalCode' => $this->getNodeValue($addressNode->getElementsByTagName('postcode')),
'postalCode' => $postalCode,
'adminLevels' => $adminLevels,
'streetNumber' => $this->getNodeValue($addressNode->getElementsByTagName('house_number')),
'streetName' => $this->getNodeValue($addressNode->getElementsByTagName('road')) ?: $this->getNodeValue($addressNode->getElementsByTagName('pedestrian')),
Expand Down
0