8000 [Photon] Reverse Geocoding with query filters by ybert · Pull Request #1195 · geocoder-php/Geocoder · GitHub
[go: up one dir, main page]

Skip to content

[Photon] Reverse Geocoding with query filters #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Feb 9, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into photon-reverse-with-osm-filters
  • Loading branch information
ybert authored Aug 2, 2023
commit 170e5a2136d3839bb1f7dfb0c9573be9409dc3b4
8 changes: 4 additions & 4 deletions src/Provider/Photon/Tests/PhotonTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public function testGeocodeQueryWithNamedResult(): void
$this->assertEquals('The Sherlock Holmes Museum and shop', $result->getName());
}

public function testGeocodeQueryWithOsmTagFilter()
public function testGeocodeQueryWithOsmTagFilter(): void
{
$provider = Photon::withKomootServer($this->getHttpClient());
$query = GeocodeQuery::create('Paris')
Expand All @@ -111,7 +111,7 @@ public function testGeocodeQueryWithOsmTagFilter()
}
}

public function testGeocodeQueryWithMultipleOsmTagFilter()
public function testGeocodeQueryWithMultipleOsmTagFilter(): void
{
$provider = Photon::withKomootServer($this->getHttpClient());
$query = GeocodeQuery::create('Paris')
Expand All @@ -127,7 +127,7 @@ public function testGeocodeQueryWithMultipleOsmTagFilter()
}
}

public function testReverseQuery()
public function testReverseQuery(): void
{
$provider = Photon::withKomootServer($this->getHttpClient());
$reverseQuery = ReverseQuery::fromCoordinates(52, 10)->withLimit(1);
Expand Down Expand Up @@ -155,7 +155,7 @@ public function testReverseQuery()
$this->assertEquals('Sehlem', $result->getDistrict());
}

public function testReverseQueryWithOsmTagFilter()
public function testReverseQueryWithOsmTagFilter(): void
{
$provider = Photon::withKomootServer($this->getHttpClient());
$reverseQuery = ReverseQuery::fromCoordinates(52.51644, 13.38890)
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.
0