I scrolled through the diff and I like it :)

The only thing that has caught my eye is the lack of space when using braced initialization eg:

-	std::vector<Ambient *> ambients;
-	std::atomic_bool active {false};
+	std::vector<Ambient*> ambients;
+	std::atomic_bool active{false};

I would have an easier time reading if the identifier was separated from the initialization like it was before.

Pretty sure that can be changed, yeah. I went with the currently prevailing style.

Yeah, it's SpaceBeforeCpp11BracedList. It also applies to cases like these, but that's fine by me:

-          Log(DEBUG, "FindPath", "Pathing failed for {}", fmt::WideToChar{caller->GetShortName()});
+          Log(DEBUG, "FindPath", "Pathing failed for {}", fmt::WideToChar {caller->GetShortName()});
-  auto key = std::string{tablename.c_str()};
+  auto key = std::string {tablename.c_str()};

yeah, that looks good

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Ok, all seems to be working fine. The pre-commit hook gets installed and makes you comply before committing anything and if anyone circumvents that the PR style checker will catch it.

Made it use annotations instead of spamming comments like sonar:
d14014b ... and apparently they don't persist after new commits, nevermind

I've cleaned up the history, but I'll wait with the big reformat stuff while all the other PRs are open. You can cherry-pick 9fc535d and a9eeeb7 (and move to .git/hooks) if you want it sooner.

Given I have so many different projects, or at least memories of them, and their presumable conventions, I'd be happy to get this at hands.

I've been using it for the past year. Sometimes it seems to suggest wrong things when just looking at the changed diff or pulls in too many other changes, but this problem will go away once we reformat (--no-verify can be used when needed until then).

I suggest we merge it after #1876.