Make TransactionOptions default to optional#612
Mer
10BC0
ged
Conversation
elprans
approved these changes
Apr 23, 2025
e65ec5c to
213dc8a
Compare
scotttrinh
approved these changes
Apr 23, 2025
Contributor
There was a problem hiding this comment.
Interesting. OK, I can match this in the JS driver as well.
Visible behavior should be the same for now. Later, once we support putting the TransactionOptions values into config, it will be important to distinguish whether they are actually set.
213dc8a to
1ffc527
Compare
msullivan
added a commit
that referenced
this pull request
Apr 29, 2025
Changes ======= * Enable reflecting of `ext` types. (by @vpetrovykh in 80a6b52) * Enable multiple modules for SQLModel reflection. (by @vpetrovykh in 8a7fdb5) * Update SQLModel generator. (by @vpetrovykh in 1d1c937) * Fix an issue with generating SQLModel with array props. (by @vpetrovykh in 2acffba) * Add encode and decode for array of array. (by @dnwpark in cc10463 for #594) * Improve nested array test skipping (by @elprans in 4dd19cb) * Fix server binary detection in WSL (by @elprans in 0d60662 for #601) * Drop Python 3.8 support (by @elprans in 1209adc for #600) * Fix reused SSLContext ALPN bug (by @fantix in 8874060 for #602) * Pin Django to ~5.1 (by @msullivan in dff941e for #610) * Make IsolationLevel enum values match the server names (by @msullivan in 7d2a401 for #611) * Make TransactionOptions default to optional (by @msullivan in 553e3ce for #612) * Implement PreferRepeatableRead, apply TransactionOptions to config state (by @msullivan in 46dae11 for #609) * Support PreferRepeatableRead on explicit transactions by retrying (by @msullivan in e1e25c0 for #616) * Make EnumValue support comparison to strings (by @msullivan in bb93ed7 for #615) * Update AI RAG response parsing. (by @dnwpark in 9060b04 for #618)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visible behavior should be the same for now. Later, once we support
putting the TransactionOptions values into config, it will be
important to distinguish whether they are actually set.
Extracted from #609.