8000 Test memory router, ensure Route onRoute is not required by lhorie · Pull Request #232 · fusionjs/fusion-plugin-react-router · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on May 17, 2019. It is now read-only.

Test memory router, ensure Route onRoute is not required#232

Merged
lhorie merged 2 commits intomasterfrom
memoryrouter
Feb 20, 2019
Merged

Test memory router, ensure Route onRoute is not required#232
lhorie merged 2 commits intomasterfrom
memoryrouter

Conversation

@lhorie
Copy link
Contributor
@lhorie lhorie commented Feb 20, 2019

Currently, using <MemoryRouter> causes an error that the onRoute context property is required by <Route>.

This PR makes onRoute optional and adds tests to ensure basic usage of MemoryRouter works

@lhorie lhorie added the bugfix label Feb 20, 2019
@codecov
Copy link
codecov bot commented Feb 20, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@17aa5bd). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #232   +/-   ##
=========================================
  Coverage          ?   79.35%           
=========================================
  Files             ?       10           
  Lines             ?      218           
  Branches          ?       48           
=========================================
  Hits              ?      173           
  Misses            ?       30           
  Partials          ?       15
Impacted Files Coverage Δ
src/modules/Route.js 76.19% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17aa5bd...5572ba5. Read the comment docs.

2 similar comments
@codecov
Copy link
codecov bot commented Feb 20, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@17aa5bd). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #232   +/-   ##
=========================================
  Coverage          ?   79.35%           
=========================================
  Files             ?       10           
  Lines             ?      218           
  Branches          ?       48           
=========================================
  Hits              ?      173           
  Misses            ?       30           
  Partials          ?       15
Impacted Files Coverage Δ
src/modules/Route.js 76.19% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17aa5bd...5572ba5. Read the comment docs.

@codecov
Copy link
codecov bot commented Feb 20, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@17aa5bd). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #232   +/-   ##
=========================================
  Coverage          ?   79.35%           
=========================================
  Files             ?       10           
  Lines             ?      218           
  Branches          ?       48           
=========================================
  Hits              ?      173           
  Misses            ?       30           
  Partials          ?       15
Impacted Files Coverage Δ
src/modules/Route.js 76.19% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17aa5bd...5572ba5. Read the comment docs.

@lhorie lhorie mentioned this pull request Feb 20, 2019
Open
@lhorie lhorie merged commit 3e9d434 into master Feb 20, 2019
@old-fusion-bot
Copy link
old-fusion-bot bot commented Feb 20, 2019

Triggered Fusion.js build verification: https://buildkite.com/uberopensource/fusion-release-verification/builds/1556

@old-fusion-bot old-fusion-bot bot deleted the memoryrouter branch February 20, 2019 16:47
@UberOpenSourceBot UberOpenSourceBot mentioned this pull request Feb 20, 2019
Merged
This was referenced Feb 21, 2019
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ganemone ganemone ganemone approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lhorie @ganemone
0