E527 Fix cases for font-face styles by angus-c · Pull Request #154 · fusionjs/fusion-plugin-font-loader-react · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on May 17, 2019. It is now read-only.

Fix cases for font-face styles#154

Merged
angus-c merged 1 commit intomasterfrom
fix-style-case
May 2, 2019
Merged

Fix cases for font-face styles#154
angus-c merged 1 commit intomasterfrom
fix-style-case

Conversation

@angus-c
Copy link
Contributor
@angus-c angus-c commented May 1, 2019

No description provided.

@angus-c angus-c requested review from KevinGrandon and alxmyth May 1, 2019 20:22
@codecov
Copy link
codecov bot commented May 1, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@5055e25). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #154   +/-   ##
=========================================
  Coverage          ?   52.63%           
=========================================
  Files             ?        9           
  Lines             ?      152           
  Branches          ?       31           
=========================================
  Hits              ?       80           
  Misses            ?       72           
  Partials          ?        0
Impacted Files Coverage Δ
src/generate-font-faces.js 95% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5055e25...72899fb. Read the comment docs.

@angus-c angus-c requested a review from derekjuber May 1, 2019 21:47
@derekjuber
Copy link
Contributor
derekjuber commented May 1, 2019

What happened with the lock file that stripped the integrity fields?

@angus-c
Copy link
Contributor Author
angus-c commented May 1, 2019

What happened with the lock file that stripped the integrity fields?

I don't know. This seems to happen randomly. Do you know what purpose the integrity fields serve?

@chrisdothtml
Copy link
Member
chrisdothtml commented May 1, 2019

See yarnpkg/yarn#6440 for info about the integrity lines

@angus-c
Copy link
Contributor Author
angus-c commented May 1, 2019

See yarnpkg/yarn#6440 for info about the integrity lines

Much clearer now 😱

@angus-c angus-c merged commit 90e2dcc into master May 2, 2019
@fusionjs-bot fusionjs-bot bot deleted the fix-style-case branch May 2, 2019 16:16
@fusionjs-bot
Copy link
fusionjs-bot bot commented May 2, 2019

Triggered Fusion.js build verification: https://buildkite.com/uberopensource/fusion-release-verification/builds/2037

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alxmyth alxmyth Awaiting requested review from alxmyth

@chrisdothtml chrisdothtml Awaiting requested review from chrisdothtml

@ganemone ganemone Awaiting requested review from ganemone

@lhorie lhorie Awaiting requested review from lhorie

@rtsao rtsao Awaiting requested review from rtsao

@derekjuber derekjuber Awaiting requested review from derekjuber

1 more reviewer

@KevinGrandon KevinGrandon KevinGrandon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@angus-c @derekjuber @chrisdothtml @KevinGrandon @UberOpenSourceBot
0