This repository was archived by the owner on May 17, 2019. It is now read-only.
Fix preload state leak#117
Merged
old-fusion-bot[bot] merged 3 commits intofusionjs:masterfrom Oct 1, 2018
Merged
Conversation
|
|
angus-c
approved these changes
Sep 26, 2018
Contributor
Author
|
!merge |
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
==========================================
+ Coverage 48% 49.21% +1.21%
==========================================
Files 8 9 +1
Lines 125 128 +3
Branches 21 21
==========================================
+ Hits 60 63 +3
Misses 65 65
Continue to review full report at Codecov.
|
Contributor
|
!merge |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the plugin was preloading fonts not based on what was rendered in the current request, but actually the set of all fonts that have been rendered by the server process in all subsequent requests. To minimize unnecessary preloads, this diff introduces a preload engine to keep track of the fonts that were rendered in the current request.