-
Notifications
You must be signed in to change notification settings - Fork 4
Basic contour label implementation #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s contours, instead of hiding them completely.
| return self._group_labels | ||
|
|
||
| @group_labels.setter | ||
| def group_labels(self, group_labels: list[int] | None = None) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| def group_labels(self, group_labels: list[int] | None = None) -> None: | |
| def group_labels(self, group_labels: list[int] | None = None) -> None: | |
| """ Set the list of nodes that should be filled instead of contoured.... """ |
| return None | ||
|
|
||
| if visible == "all": | ||
| return 0.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make a class-level constant and use that, so we can change if needed.
… that is only visible when a TracksLabels layer is present
|
I pressed D by accident and it created a key error 🙃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug as mentioned when node is deleted while in group. But otherwise I'm happy with the actual contour label changes! Also happy if you want to simplify the USERS options while keeping the backend API fully configurable.
Block selected_label event when setting colormap in _new_label to prevent infinite recursion loop. Also remove redundant colormap assignment in _ensure_valid_label since _new_label already handles it. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…_tracker into 217-contour-labels-layer
This reverts commit 7f1c123.
|
Let's just double check that the bug is indeed resolved and click around again to make sure we didn't break anything. Then merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it more thoroughly, including with orthoviews and 3d view, and everything looks great! 🍅 🦖


Implement option for displaying nodes that are not in lineage/group as contours, instead of hiding them completely. This behavior can be toggled from the Edit Menu (for now, probably should move to 'settings' eventually).
Maybe more as inspiration / intermediate state until we have figured out what we want exactly for the visualization (issues #217 , #283)